Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce candidate to wrong email address page #10289

Merged
merged 2 commits into from
Jan 21, 2025

Conversation

CatalinVoineag
Copy link
Contributor

@CatalinVoineag CatalinVoineag commented Jan 21, 2025

Context

If a candidate tries to login with the candidate email address and they have a one login email address that is different from the candidate email address. We will not allow the user to login, with one login.

We will redirect the user to the wrong_email_address page. From here the user can try to login again.

Previously we would have redirected the user to 500 error page. This page is intended to have more content helping the candidate to unstuck themselves rather than contacting support

Changes proposed in this pull request

New candidate wrong email page

Guidance to review

Screencast.2025-01-21.14.54.59.mp4

Link to Trello card

https://trello.com/c/mZLgSj2z

Things to check

  • If the code removes any existing feature flags, a data migration has also been added to delete the entry from the database
  • This code does not rely on migrations in the same Pull Request
  • If this code includes a migration adding or changing columns, it also backfills existing records for consistency
  • If this code adds a column to the DB, decide whether it needs to be in analytics yml file or analytics blocklist, if included inform data insights team of the changes
  • If this code adds a column that may include PII, the sanitise.sql script and 0025-protecting-personal-data-in-production-dump.md ADR have been updated.
  • API release notes have been updated if necessary
  • If it adds a significant user-facing change, is it documented in the CHANGELOG?
  • Attach the PR to the Trello card

@CatalinVoineag CatalinVoineag self-assigned this Jan 21, 2025
@CatalinVoineag CatalinVoineag force-pushed the cv/one-login-wrong-email-page branch from 5eeb2c7 to 24e5ee2 Compare January 21, 2025 14:53
@CatalinVoineag CatalinVoineag marked this pull request as ready for review January 21, 2025 14:56
If a candidate tries to login with the candidate email address and they
have a one login email address that is different from the candidate
email address. We will not allow the user to login, with one login.

We will redirect the user to the wrong_email_address page.

Previously we would have redirected the user to 500 error page. This
page is intended to have more content helping the candidate to unstuck
themselves rather than contacting support
Copy link
Contributor

@elceebee elceebee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be good to use the govuk_mail_to helper for consistency, but otherwise this looks good to me! It's a much better experience for the user.

@CatalinVoineag CatalinVoineag merged commit f051ef7 into main Jan 21, 2025
23 checks passed
@CatalinVoineag CatalinVoineag deleted the cv/one-login-wrong-email-page branch January 21, 2025 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants